- Mar 13, 2012
-
-
Rene Saarsoo authored
-
Rene Saarsoo authored
To support Google Closure Compiler syntax for optional parameters. @param {Type=} name This is detected at DocParser not in TypeParser like the rest of the type definition syntax - all other way of defining optional parameters are also implemented in DocParser, so it keeps things simpler to have it all in there at one spot.
-
Rene Saarsoo authored
In supporting Google Closure Compiler syntax.
-
Rene Saarsoo authored
-
Rene Saarsoo authored
In supporting Google Closure Compiler syntax.
-
Rene Saarsoo authored
The syntax used by Google Closure Compiler.
-
- Mar 12, 2012
-
-
Rene Saarsoo authored
Supported by Google Closure Compiler.
-
Rene Saarsoo authored
-
Rene Saarsoo authored
It was deprecated in 3.2.1 in December 2011. Should be OK to remove now.
-
Rene Saarsoo authored
We can now have input files in any encoding as long as --encoding option specifies it correctly. When encoding differs from UTF-8, we convert the text to UTF-8 internally and always output in UTF-8 also. This option only works in Ruby 1.9. Under 1.8 it has no effect.
-
Rene Saarsoo authored
In Ruby 1.9 reading files through builtin IO class attempted to auto-detect the encoding which sometimes failed. Created JsDuck::IO to be used instead of it, which forces all files to be treated as UTF-8. It also behaves well in Ruby 1.8 - just doing nothing with the input and causing no errors.
-
- Mar 09, 2012
-
-
Rene Saarsoo authored
Recent changes in server now allow any links to be posted.
-
Rene Saarsoo authored
For now it's just dead code. Better remove before it becomes a problem.
-
Rene Saarsoo authored
Instead of supplying it in every request config object.
-
Rene Saarsoo authored
It deals with extracting data from form, and the form is described in view. So it really is the specifics that should belong to view. So the view now does the extracting of data and then calls Auth.login().
-
Rene Saarsoo authored
Using the same function now in both Auth and Comments controllers.
-
Rene Saarsoo authored
Rename several methods: - loggedIn -> setLoggedIn - loggedOut -> setLoggedOut For setting the state of login form. - getSession -> retreveSession "get" is a bad start for method that doesn't return a value. - showLogin -> showLoginForm Previously it was hard to distinguish it from showLoggedIn. - loggedIn -> isLoggedIn Now the method for checking logged in status is named the same way in both Auth and AuthHelpers. This also differenciates it from the event "loggedIn".
-
Rene Saarsoo authored
Currently used nowhere, not supported by backend either.
-
Rene Saarsoo authored
All Ajax and JsonP request for comments data are now performed through a custom #request method that appends server and session ID data to the given URL.
-
Rene Saarsoo authored
I didn't notice before that there was a #showError method already, so I created #notify method to notify of subscription changes. Merging these two methods now into #notify to cover both uses. The method now takes a third argument to allow for anchoring on different sides. One downside is, that I threw out the smooth fade-in and fade-out of subscription notification. It was a bit of a too much trouble for such a small feature, so I guess the overall simplicity in code is a win.
-
Rene Saarsoo authored
-
Rene Saarsoo authored
- correctly reference sdk-vars.rb from local dir. - add coding-comments where needed. - Use real unicode characters in tests and regexes instead of escape-sequences of byte values.
-
- Mar 08, 2012
-
-
Rene Saarsoo authored
Create a validator that checks if user is allowed to edit current comment, use it for such a check when updating, deleting and undoing deletes.
-
Rene Saarsoo authored
Instead of showing a Yes/No prompt before deleting a comment, delete the comment right away and replace it with link to undo the delete action. This was easy to accomplish as we never delete the comments, but just mark them as deleted in database.
-
Rene Saarsoo authored
The same HTML was created in two places. Now it's in single spot at Docs.view.Comments#getPagerHtml. The HTML is now also more straight-forward, allowing us easily to display either link or plain text inside the pager container.
-
Rene Saarsoo authored
It's helpful to know how many comments there are in total. Previously you didn't see the total count when there was < 100.
-
Rene Saarsoo authored
This stopped working after switching to MongoDB, as the recent_comments query no more returned the total_rows and other parameters needed for creating the "Load more..." link. Also fixed the "Load more..." link to always show the nr of comments that are to be loaded.
-
- Mar 07, 2012
-
-
Rene Saarsoo authored
Previously the comments idMap didn't contain the static members at all, so when new comment was posted, its target was set to ["unknown"].
-
Rene Saarsoo authored
Rename some functions to better reflect what they do: - sanitize --> markdown - formatComments --> scoreComments - getCommentsMeta --> getCommentCounts
-
Rene Saarsoo authored
Just helpful when starting up the server for the first time.
-
Rene Saarsoo authored
-
Rene Saarsoo authored
There was an opts parameter which attempted enabling sencha.com/* URL-s, but this option wasn't used anywhere the function was called from - besides the option didn't work because some code before it attempted turning all URL-s into links, but mistakenly also picked up URL-s within href="...". Anyway, I see no reason to only allow links to sencha.com, so allowing all links, whatever they may be. The code for convering URL-s to links is not needed at all because the 'marked' module does this already.
-
Rene Saarsoo authored
Because overrides can be circular (Notably Ext.Base#destroy), store into overrides array just the name,owner,id of the overridden member, not the member hash itself - previously we stored the actual member hash, which in case of circular overrides resulted in infinite loop when serializing the class into JSON.
-
- Mar 06, 2012
-
-
Rene Saarsoo authored
Fixing a regression introduced by sorting instance and static members intermixed.
-
- Mar 05, 2012
-
-
Rene Saarsoo authored
-
Rene Saarsoo authored
There's too much happening in DocFormatter, moving these things to separate classes, will make it a little bit cleaner.
-
Rene Saarsoo authored
For now implementing two types: {@video html5 some/url.mpeg Comment...} {@video vimeo 8791231354 Comment...} With future possibility of allowing users define their own types.
-
Rene Saarsoo authored
-
Rene Saarsoo authored
This allows easy embedding of videos to guides (and even to class docs if there should be such need). For now only supporting Vimeo videos, just like the separate videos page: {@video <vimeo-video-id> Some comment}
-
Rene Saarsoo authored
Previously when class Foo happened to be listed before Foo.Bar, the Foo node was created and Bar added as a child to it, but Foo was left to be a leaf node, which meant its children were invisible, making the class-tree look broken.
-