Skip to content
Snippets Groups Projects
  1. Mar 08, 2012
    • Rene Saarsoo's avatar
      Implement undo for deleting comments. · be5af754
      Rene Saarsoo authored
      Instead of showing a Yes/No prompt before deleting a comment, delete the
      comment right away and replace it with link to undo the delete action.
      
      This was easy to accomplish as we never delete the comments, but just
      mark them as deleted in database.
      be5af754
    • Rene Saarsoo's avatar
      Eliminate duplicate code for comments pager. · ba5fffa4
      Rene Saarsoo authored
      The same HTML was created in two places. Now it's in single spot at
      Docs.view.Comments#getPagerHtml.
      
      The HTML is now also more straight-forward, allowing us easily to
      display either link or plain text inside the pager container.
      ba5fffa4
    • Rene Saarsoo's avatar
      Display total count when no more comments to load. · 4525e349
      Rene Saarsoo authored
      It's helpful to know how many comments there are in total.
      Previously you didn't see the total count when there was < 100.
      4525e349
    • Rene Saarsoo's avatar
      Paging of recent comments. · 23fb66e6
      Rene Saarsoo authored
      This stopped working after switching to MongoDB, as the recent_comments
      query no more returned the total_rows and other parameters needed for
      creating the "Load more..." link.
      
      Also fixed the "Load more..." link to always show the nr of comments
      that are to be loaded.
      23fb66e6
  2. Mar 07, 2012
    • Rene Saarsoo's avatar
      Fix commenting on static members. · 2f1dfb03
      Rene Saarsoo authored
      Previously the comments idMap didn't contain the static members at all,
      so when new comment was posted, its target was set to ["unknown"].
      2f1dfb03
    • Rene Saarsoo's avatar
      Refactor and comment comments util.js · c3bc2c28
      Rene Saarsoo authored
      Rename some functions to better reflect what they do:
      
      - sanitize --> markdown
      - formatComments --> scoreComments
      - getCommentsMeta --> getCommentCounts
      c3bc2c28
    • Rene Saarsoo's avatar
      Print out on which port the comments server runs. · d4ba4d54
      Rene Saarsoo authored
      Just helpful when starting up the server for the first time.
      d4ba4d54
    • Rene Saarsoo's avatar
      Add missing semicolons. · 86f039f8
      Rene Saarsoo authored
      86f039f8
    • Rene Saarsoo's avatar
      Allow posting links in comments. · 6a5a2c4c
      Rene Saarsoo authored
      There was an opts parameter which attempted enabling sencha.com/* URL-s,
      but this option wasn't used anywhere the function was called from -
      besides the option didn't work because some code before it attempted
      turning all URL-s into links, but mistakenly also picked up URL-s
      within href="...".
      
      Anyway, I see no reason to only allow links to sencha.com, so allowing
      all links, whatever they may be.
      
      The code for convering URL-s to links is not needed at all because the
      'marked' module does this already.
      6a5a2c4c
    • Rene Saarsoo's avatar
      Fix infinite loop when exporting JSON. · bdc840cb
      Rene Saarsoo authored
      Because overrides can be circular (Notably Ext.Base#destroy),
      store into overrides array just the name,owner,id of the overridden
      member, not the member hash itself - previously we stored the
      actual member hash, which in case of circular overrides resulted
      in infinite loop when serializing the class into JSON.
      bdc840cb
  3. Mar 06, 2012
  4. Mar 05, 2012
  5. Mar 03, 2012
  6. Mar 02, 2012
  7. Mar 01, 2012
  8. Feb 29, 2012
  9. Feb 28, 2012
    • Rene Saarsoo's avatar
      Refactor Rakefile to work with different ExtJS versions. · 252e22e4
      Rene Saarsoo authored
      The extjs/ subdir in JSDuck output is now dedicated to the ExtJS
      which the Docs app itself uses.
      
      For examples to work, a separate directory (by default extjs-build/)
      should be created and referenced from eg-iframe.html and examples.
      252e22e4
    • Rene Saarsoo's avatar
      Use --examples-base-url also used for icons. · 20896e51
      Rene Saarsoo authored
      Instead of hardcoding ExtJS and Touch examples paths, the
      --examples-base-url option determines where icons are located.
      
      The important change is that examples.json file now has to define
      icons relative to --examples-base-url (this was the case for Touch,
      but not for ExtJS).
      
      Example title and description fields are now also correctly convered,
      independent of url being absolute or not.
      
      Auto-created example name no more contains the --examples-base-url
      in it.
      20896e51
    • Nick Poulden's avatar
      Sendmail for comment subscriptions · f65653c3
      Nick Poulden authored
      f65653c3
    • Nick Poulden's avatar
      Comment subscriptions · 4acb9722
      Nick Poulden authored
      4acb9722
  10. Feb 27, 2012
Loading