Skip to content
Unverified Commit 761cdf98 authored by Morris Jobke's avatar Morris Jobke
Browse files

Remove deprecated test of internal attributes via assertAttributeEquals in constructor tests

I removed the tests completely because they just test that the constructor assigns the values to the internal properties. Nothing that should be cared about from the outside.

See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-428843322



It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls.

Signed-off-by: default avatarMorris Jobke <hey@morrisjobke.de>
parent 1339ea15
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment