Skip to content
Unverified Commit 0299ea0a authored by Christoph Wurst's avatar Christoph Wurst Committed by Roeland Jago Douma
Browse files

Handle token insert conflicts



Env-based SAML uses the "Apache auth" mechanism to log users in. In this
code path, we first delete all existin auth tokens from the database,
before a new one is inserted. This is problematic for concurrent
requests as they might reach the same code at the same time, hence both
trying to insert a new row wit the same token (the session ID). This
also bubbles up and disables user_saml.

As the token might still be OK (both request will insert the same data),
we can actually just check if the UIDs of the conflict row is the same
as the one we want to insert right now. In that case let's just use the
existing entry and carry on.

Signed-off-by: default avatarChristoph Wurst <christoph@winzerhof-wurst.at>
parent dfe85ae0
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment