- Mar 20, 2017
-
-
Samuel Alfageme authored
(cherry picked from commit ed03cdf4)
-
Matthew Setter authored
This fixes #5609.
-
Samuel Alfageme authored
This was a request of @michaelstingl to document how to configure the proxy manually via the .cfg file for config provisioning purposes. - Restructured the bullet points into 3 different tables; I believe it's a cleaner approach; maybe this is also applicable to other sections. - Would be logical to include also settings on proxy auth?
-
Olivier Goffart authored
When there is no errors _syncResult.firstItemError() is NULL, and accessing it's _file member is an undefined behavior. (Thankfully, createGuiLog did not use the string when the count was 0, but we are not supposed to create null references. Found with the UB sanitizer: src/gui/folder.cpp:348:49: runtime error: member access within null pointer of type 'OCC::SyncFileItem' src/gui/folder.cpp:348:19: runtime error: reference binding to null pointer of type 'const QString'
-
Jenkins for ownCloud authored
-
- Mar 19, 2017
-
-
Jenkins for ownCloud authored
-
- Mar 18, 2017
-
-
Jenkins for ownCloud authored
-
- Mar 17, 2017
-
-
Jenkins for ownCloud authored
-
- Mar 16, 2017
-
-
Olivier Goffart authored
The backtrace seems to indicate that the account is invalid. I don't know how this can happen, maybe the account's display name was changed while the app is running? Backtrace: Crash: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS at 0x18 Module "owncloud", in OCC::AccountState::account Module "owncloud", in OCC::ActivityListModel::data Module "owncloud", in OCC::ActivityItemDelegate::paint Module "QtWidgets", in QListView::paintEvent Module "QtWidgets", in QWidget::event Module "QtWidgets", in QFrame::event Module "QtWidgets", in QAbstractScrollArea::viewportEvent Module "QtWidgets", in QAbstractItemView::viewportEvent Module "QtWidgets", in QAbstractScrollAreaFilter::eventFilter Module "QtCore", in QCoreApplicationPrivate::sendThroughObjectEventFilters
-
Olivier Goffart authored
The destructor of the PropagateItemJob will access the propagator's _activeJobList. So the _rootJob needs to be destroyed before it. Order of destruction is the reverse of the order of the members in the class. So put it at the end so it can be destroyed first. (This made TestSyncEngine::testDirDownloadWithError crash sometimes in the master branch)
-
Markus Goetz authored
-
Christian Kamm authored
I didn't want to touch this visible translated string in a patch release so I just switched the data. For Qt versions before 5, we continue to show the build-time version of OpenSSL but it's clearly marked as such.
-
Olivier Goffart authored
In 8ef11a38, we started blacklisting SoftError for 0 seconds. But if the two sync happen with less than 1s interval, we would still prevent them to happen. So make sure we expire if 0 seconds have expired
-
Jenkins for ownCloud authored
-
- Mar 15, 2017
-
-
Olivier Goffart authored
The backtrace looks like: File "atomic_base.h", line 396, in QString::~QString File "qlist.h", line 442, in OCC::FolderStatusModel::slotUpdateDirectories This is the only QList operation, and it may crash if the list is empty. It can be empty if the propfind returned empty results. I'm not sure how this can be possible to have an empty list there since the server is always supposed to return at least one entry, for the directory itself. But it can happen if a directory was transformed in a file, or if there is a bug on the server.
-
Christian Kamm authored
See also owncloud/core#27360
-
Christian Kamm authored
Hex literals don't work well with version 10: 0x100000 doesn't do the right thing.
-
Olivier Goffart authored
The previous patch on this file made it a bit too big, so make it a bit smaller For issue #5600
-
Jenkins for ownCloud authored
-
- Mar 14, 2017
-
-
Christian Kamm authored
* Add git revision, if available * Add SSL runtime version * Add compile-time Qt version
-
Christian Kamm authored
It is possible to create files with filenames that differ only by case in NTFS, but most operations such as stat and open only target one of these by default. When that happens, we want to avoid uploading incorrect data and give up on the file. Typically this situation should never occurr during normal use of Windows. It can happen, however, when a NTFS partition is mounted in another OS.
-
Jenkins for ownCloud authored
-
- Mar 13, 2017
-
-
Olivier Goffart authored
So the title of the column is fully visible. Adjust the default size and the size policy of the label so it behave correctly as the window get resized Issue #5600
-
Jenkins for ownCloud authored
-
- Mar 12, 2017
-
-
Jenkins for ownCloud authored
-
- Mar 11, 2017
-
-
Jenkins for ownCloud authored
-
- Mar 10, 2017
-
-
Christian Kamm authored
-
Jenkins for ownCloud authored
-
- Mar 09, 2017
-
-
Olivier Goffart authored
The crash reporter shows many crashes in OwncloudPropagator::scheduleNextJob. We don't really know what could be the cause, but it's probably because the _activeJobList contains dangling pointer. So this patch makes sure to remove all the jobs from this list as they get destroyed.
-
Jenkins for ownCloud authored
-
- Mar 08, 2017
-
-
Jenkins for ownCloud authored
-
- Mar 07, 2017
-
-
Christian Kamm authored
* For requests: - reuse the original QNetworkRequest, so headers and attributes are the same as in the original request - determine the original http method from the reply and the request attributes - keep the original request body around such that it can be sent again in case the request is redirected * Simplify the interface that is used for creating new requests in AbstractNetworkJob.
-
Jenkins for ownCloud authored
-
Jenkins for ownCloud authored
-
- Mar 06, 2017
-
-
Olivier Goffart authored
Backtrace from the crash reporter: Crash: EXCEPTION_ACCESS_VIOLATION_READ at 0x401 File "moc_activitylistmo_M5OEXJ7XGJYTWT.cpp", line 92, in OCC::ActivityListModel::qt_static_metacall File "qobject.cpp", line 3730, in QMetaObject::activate File "moc_networkjobs_7AMNCW4BBANVRK.cpp", line 1342, in OCC::JsonApiJob::jsonReceived File "networkjobs.cpp", line 714, in OCC::JsonApiJob::finished File "abstractnetworkjob.cpp", line 207, in OCC::AbstractNetworkJob::slotFinished File "moc_abstractnetwor_PFI2TXGQHRE33H.cpp", line 98, in OCC::AbstractNetworkJob::qt_static_metacall File "qobject.cpp", line 3730, in QMetaObject::activate File "moc_qnetworkreply.cpp", line 367, in QNetworkReply::finished File "qnetworkreplyhttpimpl.cpp", line 2100, in QNetworkReplyHttpImplPrivate::finished File "qnetworkreplyhttpimpl.cpp", line 279, in QNetworkReplyHttpImpl::abort My theory is that the AccountState stored in a property of the job was destroyed. before the job timed out. Therefore, the qobject_cast within the qvariant_cast would call the metaObject() virtual function on a dangling pointer. Fix it by storing a QPointer instead which will track the deletion.
-
Olivier Goffart authored
When there is a FatalError, we ended up emiting the finished signal for the directory job several times, which would lead to crashes Issue #5578
-
Markus Goetz authored
-
- Mar 05, 2017
-
-
Jenkins for ownCloud authored
-
- Mar 04, 2017
-
-
Jenkins for ownCloud authored
-
- Mar 03, 2017
-
-
Olivier Goffart authored
-