Skip to content
  1. Mar 20, 2017
  2. Mar 19, 2017
  3. Mar 18, 2017
  4. Mar 17, 2017
  5. Mar 16, 2017
    • Olivier Goffart's avatar
      ActivityListModel: attempt to fix a crash. · a6037025
      Olivier Goffart authored
      The backtrace seems to indicate that the account is invalid.
      I don't know how this can happen, maybe the account's display
      name was changed while the app is running?
      
      Backtrace:
      Crash: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS at 0x18
        Module "owncloud", in OCC::AccountState::account
        Module "owncloud", in OCC::ActivityListModel::data
        Module "owncloud", in OCC::ActivityItemDelegate::paint
        Module "QtWidgets", in QListView::paintEvent
        Module "QtWidgets", in QWidget::event
        Module "QtWidgets", in QFrame::event
        Module "QtWidgets", in QAbstractScrollArea::viewportEvent
        Module "QtWidgets", in QAbstractItemView::viewportEvent
        Module "QtWidgets", in QAbstractScrollAreaFilter::eventFilter
        Module "QtCore", in QCoreApplicationPrivate::sendThroughObjectEventFilters
      a6037025
    • Olivier Goffart's avatar
      Propagator: change order of destruction · 21909cae
      Olivier Goffart authored
      The destructor of the PropagateItemJob will access the propagator's
      _activeJobList. So the _rootJob needs to be destroyed before it.
      Order of destruction is the reverse of the order of the members in
      the class. So put it at the end so it can be destroyed first.
      
      (This made TestSyncEngine::testDirDownloadWithError crash sometimes
      in the master branch)
      21909cae
    • Markus Goetz's avatar
      ChangeLog for 2.3.1 · 176ea20f
      Markus Goetz authored
      176ea20f
    • Christian Kamm's avatar
      About: Show the runtime versions of Qt and OpenSSL #5592 · 1a279ca1
      Christian Kamm authored
      I didn't want to touch this visible translated string in a
      patch release so I just switched the data.
      
      For Qt versions before 5, we continue to show the build-time version
      of OpenSSL but it's clearly marked as such.
      1a279ca1
    • Olivier Goffart's avatar
      SyncEngine: fix test regression in TestChunkingNG::testCreateConflictWhileSyncing · 0ed929f2
      Olivier Goffart authored
      In 8ef11a38, we started blacklisting
      SoftError for 0 seconds.  But if the two sync happen with less than
      1s interval, we would still prevent them to happen.
      So make sure we expire if 0 seconds have expired
      0ed929f2
    • Jenkins for ownCloud's avatar
      [tx-robot] updated from transifex · 41eeed98
      Jenkins for ownCloud authored
      41eeed98
  6. Mar 15, 2017
  7. Mar 14, 2017
  8. Mar 13, 2017
  9. Mar 12, 2017
  10. Mar 11, 2017
  11. Mar 10, 2017
  12. Mar 09, 2017
  13. Mar 08, 2017
  14. Mar 07, 2017
  15. Mar 06, 2017
    • Olivier Goffart's avatar
      ActivityListModel: fix possible crash in slotActivitiesReceived · f4495c5c
      Olivier Goffart authored
      Backtrace from the crash reporter:
      
      Crash: EXCEPTION_ACCESS_VIOLATION_READ at 0x401
        File "moc_activitylistmo_M5OEXJ7XGJYTWT.cpp", line 92, in OCC::ActivityListModel::qt_static_metacall
        File "qobject.cpp", line 3730, in QMetaObject::activate
        File "moc_networkjobs_7AMNCW4BBANVRK.cpp", line 1342, in OCC::JsonApiJob::jsonReceived
        File "networkjobs.cpp", line 714, in OCC::JsonApiJob::finished
        File "abstractnetworkjob.cpp", line 207, in OCC::AbstractNetworkJob::slotFinished
        File "moc_abstractnetwor_PFI2TXGQHRE33H.cpp", line 98, in OCC::AbstractNetworkJob::qt_static_metacall
        File "qobject.cpp", line 3730, in QMetaObject::activate
        File "moc_qnetworkreply.cpp", line 367, in QNetworkReply::finished
        File "qnetworkreplyhttpimpl.cpp", line 2100, in QNetworkReplyHttpImplPrivate::finished
        File "qnetworkreplyhttpimpl.cpp", line 279, in QNetworkReplyHttpImpl::abort
      
      My theory is that the AccountState stored in a property of the job was destroyed.
      before the job timed out.
      Therefore, the qobject_cast within the qvariant_cast would call the metaObject()
      virtual function on a dangling pointer.
      
      Fix it by storing a QPointer instead which will track the deletion.
      f4495c5c
    • Olivier Goffart's avatar
      Propagator: Fix finished signal of directory being emited twice and causing crash · f862c626
      Olivier Goffart authored
      When there is a FatalError, we ended up emiting the finished signal for
      the directory job several times, which would lead to crashes
      
      Issue #5578
      f862c626
    • Markus Goetz's avatar
      NSIS: Don't display link on finish page · 6487bb07
      Markus Goetz authored
      6487bb07
  16. Mar 05, 2017
  17. Mar 04, 2017
  18. Mar 03, 2017