Skip to content
  1. Sep 29, 2012
  2. Sep 27, 2012
  3. Sep 26, 2012
  4. Sep 25, 2012
  5. Sep 24, 2012
  6. Sep 22, 2012
    • Vojtech Juranek's avatar
      Added changelog for 452f4f1c · 823cda1a
      Vojtech Juranek authored
      823cda1a
    • Vojtech Juranek's avatar
    • Kohsuke Kawaguchi's avatar
      Missing @since · 4b4d35d2
      Kohsuke Kawaguchi authored
      4b4d35d2
    • Kohsuke Kawaguchi's avatar
      simplification · 550afcc9
      Kohsuke Kawaguchi authored
      550afcc9
    • Kohsuke Kawaguchi's avatar
      reducing variable scope · 7917ccb7
      Kohsuke Kawaguchi authored
      7917ccb7
    • Kohsuke Kawaguchi's avatar
      Fixing concurrency problems. · 1f38518f
      Kohsuke Kawaguchi authored
      The following bug report from olamy made me look hard at the code, but I'm not spotting an obvious problem.
      The binary search algorithm here seems to always satisfy the invariant of 0<=lo<=pivot<=hi<=size, so I can't understand how lo==size+1 at the end, for this to happen.
      
      So the only thing I can think of is concurrency related, which is indeed buggy --- we are editing indices after they are set to instance fields, which violates the copy-on-write semantics. This commit fixes that.
      
      Sep 21, 2012 9:38:35 PM jenkins.InitReactorRunner$1 onTaskFailed
      SEVERE: Failed Loading job MahoutQM
      java.lang.IndexOutOfBoundsException: Index: 1, Size: 1
      	at java.util.ArrayList.rangeCheck(ArrayList.java:604)
      	at java.util.ArrayList.get(ArrayList.java:382)
      	at jenkins.model.lazy.SortedList.get(SortedList.java:60)
      	at jenkins.model.lazy.AbstractLazyLoadRunMap.search(AbstractLazyLoadRunMap.java:381)
      	at jenkins.model.lazy.AbstractLazyLoadRunMap.newestBuild(AbstractLazyLoadRunMap.java:243)
      	at hudson.model.AbstractProject.getLastBuild(AbstractProject.java:998)
      	at hudson.maven.AbstractMavenProject.createTransientActions(AbstractMavenProject.java:184)
      	at hudson.model.AbstractProject.updateTransientActions(AbstractProject.java:665)
      	at hudson.maven.MavenModule.updateTransientActions(MavenModule.java:411)
      	at hudson.model.AbstractProject.onLoad(AbstractProject.java:299)
      	at hudson.maven.MavenModule.onLoad(MavenModule.java:236)
      	at hudson.model.Items.load(Items.java:221)
      	at hudson.model.ItemGroupMixIn.loadChildren(ItemGroupMixIn.java:99)
      1f38518f
    • Kohsuke Kawaguchi's avatar
      tweaking the co-efficient · de15893c
      Kohsuke Kawaguchi authored
      de15893c
    • Kohsuke Kawaguchi's avatar
      don't do this by default · 2bc20ad2
      Kohsuke Kawaguchi authored
      2bc20ad2