Skip to content
  • Kohsuke Kawaguchi's avatar
    [FIXED JENKINS-7291] Permit flyweight tasks to run on master even when it has... · a114c693
    Kohsuke Kawaguchi authored
    [FIXED JENKINS-7291] Permit flyweight tasks to run on master even when it has zero configured executors.
    
    Always adding Computer for master as a fallback
    
    The original proposed fix for JENKINS-7291 creates a Computer object
    transitively. This seems unwise as it violates the design of Computer
    as stated in the javadoc, and for example we can end up creating two
    Computers for the master.
    
    I think a better fix is to create a Computer for the master all the
    time, even if there's no executors configured. The discrimination in
    Queue.makeBuildable would ensure that such phantom Computer is only used
    as a last resort (statistically speaking).
    
    I've also tweaked executors.jelly a bit. I simplified it somewhat
    based on the idea that "if there's only one computer to show, the
    context is likely making it obvious".
    
    (I must be missing the intricacy in the current code.)
    
    Originally developed in a branch at
    2c5b57fcc1f39ed39057254e802f4183db5aa0dc then squashed for clarity.
    a114c693
To find the state of this project's repository at the time of any of these versions, check out the tags.
Loading