Commit b0472cce authored by Rene Saarsoo's avatar Rene Saarsoo
Browse files

Disable all warnings in testing, enable most when running app. 

The Logger class now disables all warnings by default, which is good
for testing.  When running JSDuck app, the needed warnings are
enables explicitly by Options class.
parent aff0e736

lib/jsduck/logger.rb

+4 −3
Original line number Diff line number Diff line
@@ -38,12 +38,13 @@ module JsDuck 
        [:cat_class_missing, "Class is missing from categories file"],

        [:guide, "Guide is missing from --guides dir"],

      ]

      # Turn on all warnings except :link_auto

      # Turn off all warnings by default.

      # This is good for testing.

      # When running JSDuck app, the Options class enables most warnings.

      @warnings = {}

      @warning_docs.each do |w|

        @warnings[w[0]] = true

        @warnings[w[0]] = false

      end

      set_warning(:link_auto, false)



      @shown_warnings = {}

    end

lib/jsduck/options.rb

+4 −0
Original line number Diff line number Diff line
@@ -105,6 +105,10 @@ module JsDuck 
      @local_storage_db = "docs"

      @touch_examples_ui = false

      @ext_namespaces = ["Ext"]



      # enable all warnings except :link_auto

      Logger.instance.set_warning(:all, true)

      Logger.instance.set_warning(:link_auto, false)

    end



    # Make options object behave like hash.

spec/aggregator_classes_spec.rb

+0 −4
Original line number Diff line number Diff line
@@ -3,10 +3,6 @@ require "jsduck/source_file" 


describe JsDuck::Aggregator do



  before(:all) do

    JsDuck::Logger.instance.set_warning(:alt_name, false)

  end



  def parse(string)

    agr = JsDuck::Aggregator.new

    agr.aggregate(JsDuck::SourceFile.new(string))

spec/aggregator_inheritdoc_spec.rb

+0 −2
Original line number Diff line number Diff line
@@ -3,14 +3,12 @@ require "jsduck/source_file" 
require "jsduck/class"

require "jsduck/relations"

require "jsduck/inherit_doc"

require "jsduck/logger"

require "jsduck/tag/static"

require "jsduck/meta_tag_registry"



describe JsDuck::Aggregator do

  before(:all) do

    JsDuck::MetaTagRegistry.instance.register([JsDuck::Tag::Static.new])

    JsDuck::Logger.instance.set_warning(:inheritdoc, false)

  end



  def parse(string)

spec/class_spec.rb

+0 −5
Original line number Diff line number Diff line
@@ -2,11 +2,6 @@ require "jsduck/class" 


describe JsDuck::Class do



  # Avoid printed warnings in output

  before do

    JsDuck::Logger.instance.set_warning(:all, false)

  end



  describe "#members" do



    before do