Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
J
jsduck
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
extjs
jsduck
Commits
a5373fe0
Commit
a5373fe0
authored
12 years ago
by
Rene Saarsoo
Browse files
Options
Downloads
Patches
Plain Diff
Change owner of member when applying override.
parent
9be0542f
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
lib/jsduck/override.rb
+1
-0
1 addition, 0 deletions
lib/jsduck/override.rb
spec/aggregator_overrides_spec.rb
+8
-0
8 additions, 0 deletions
spec/aggregator_overrides_spec.rb
with
9 additions
and
0 deletions
lib/jsduck/override.rb
+
1
−
0
View file @
a5373fe0
...
...
@@ -60,6 +60,7 @@ module JsDuck
else
add_member
(
target
,
m
)
add_doc
(
m
,
"**Defined in override
#{
override
[
:name
]
}
.**"
)
m
[
:owner
]
=
target
[
:name
]
end
end
end
...
...
This diff is collapsed.
Click to expand it.
spec/aggregator_overrides_spec.rb
+
8
−
0
View file @
a5373fe0
...
...
@@ -148,6 +148,10 @@ describe JsDuck::Aggregator do
methods
[
"bar"
][
:doc
].
should
==
"Bar comment.
\n\n
**Defined in override FooOverride.**"
end
it
"changes owner of bar method to target class"
do
methods
[
"bar"
][
:owner
].
should
==
"Foo"
end
it
"keeps the foobar method that's in both original and override"
do
methods
[
"foobar"
].
should_not
==
nil
end
...
...
@@ -159,6 +163,10 @@ describe JsDuck::Aggregator do
it
"adds override source to list of files to overridden member"
do
methods
[
"foobar"
][
:files
].
length
.
should
==
2
end
it
"keeps owner of foobar method to be the original class"
do
methods
[
"foobar"
][
:owner
].
should
==
"Foo"
end
end
describe
"comment-less @override for a class"
do
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment