Commit 59c512c5 authored by Rene Saarsoo's avatar Rene Saarsoo
Browse files

Simplified HTML for members list. 

- Removed empty anchor tag - using id attribute on h3 instead.
- Replaced cryptic classname "p" with "members-title".
- Adding a differenciating ID to the parent div and using
  descendants selector to set icon for the contained h3.
parent b9dfd3a7

template/js/OverviewPanel.js

+8 −12
Original line number Diff line number Diff line
@@ -83,34 +83,30 @@ Ext.define('Docs.OverviewPanel', { 
            '<div class="doc-overview-content">',

            '{doc}',

            '<div class="members">',

                '<div class="m-cfgs">',

                '<div id="m-cfg">',

                    '<div class="definedBy">Defined By</div>',

                    '<a name="configs"></a>',

                    '<h3 class="cfg p">Config Options</h3>',

                    '<h3 class="members-title">Config Options</h3>',

                    '<tpl for="cfg">',

                        '{[this.renderMember(values)]}',

                    '</tpl>',

                '</div>',

                '<div class="m-properties">',

                '<div id="m-property">',

                    '<div class="definedBy">Defined By</div>',

                    '<a name="properties"></a>',

                    '<h3 class="prp p">Properties</h3>',

                    '<h3 class="members-title">Properties</h3>',

                    '<tpl for="property">',

                        '{[this.renderMember(values)]}',

                    '</tpl>',

                '</div>',

                '<div class="m-methods">',

                '<div id="m-method">',

                    '<div class="definedBy">Defined By</div>',

                    '<a name="methods"></a>',

                    '<h3 class="mth p">Methods</h3>',

                    '<h3 class="members-title">Methods</h3>',

                    '<tpl for="method">',

                        '{[this.renderMember(values)]}',

                    '</tpl>',

                '</div>',

                '<div class="m-events">',

                '<div id="m-event">',

                    '<div class="definedBy">Defined By</div>',

                    '<a name="events"></a>',

                    '<h3 class="evt p">Events</h3>',

                    '<h3 class="members-title">Events</h3>',

                    '<tpl for="event">',

                        '{[this.renderMember(values)]}',

                    '</tpl>',

template/resources/sass/style.scss

+10 −10
Original line number Diff line number Diff line
@@ -580,18 +580,18 @@ pre, code, kbd, samp, tt { 
      color: #666666; }

    h3.pa {

      padding: 10px 0 5px 0; }

    h3.p {

    h3.members-title {

      padding: 15px 0 10px 30px;

      font-size: 1.3em;

      font-weight: bold;

      &.cfg {

      font-weight: bold; }

    #m-cfg .members-title {

      background: url(../images/configs.png) no-repeat 0 15px; }

      &.prp {

    #m-property .members-title {

      background: url(../images/properties.png) no-repeat 0 19px; }

      &.mth {

    #m-method .members-title {

      background: url(../images/methods.png) no-repeat 0 16px; }

      &.evt {

        background: url(../images/events.png) no-repeat 0 11px; } }

    #m-event .members-title {

      background: url(../images/events.png) no-repeat 0 11px; }

    ul ul {

      list-style: circle;

      margin-top: 1em; }