Commit 3d63f8e7 authored by Rene Saarsoo's avatar Rene Saarsoo
Browse files

Refactor masking of recent comments page. 

Add #setMasked method to comments view and use that for
masking/unmasking.
parent 2e1c0274

template/app/controller/Comments.js

+2 −16
Original line number Diff line number Diff line
@@ -292,14 +292,14 @@ Ext.define('Docs.controller.Comments', { 
            params.sortByScore = 1;

        }



        this.maskComments();

        this.getIndex().setMasked(true);



        this.request("jsonp", {

            url: '/comments_recent',

            method: 'GET',

            params: params,

            success: function(response) {

                this.unmaskComments();

                this.getIndex().setMasked(false);



                this.renderComments(response, 'recentcomments', {

                    hideCommentForm: true,
@@ -311,20 +311,6 @@ Ext.define('Docs.controller.Comments', { 
        });

    },



    maskComments: function() {

        var container = Ext.get('comment-index-container');

        if (container) {

            container.mask();

        }

    },



    unmaskComments: function() {

        var container = Ext.get('comment-index-container');

        if (container) {

            container.unmask();

        }

    },



    isChecked: function(id) {

        var cb = Ext.get(id);

        return cb && cb.dom.checked;

template/app/view/comments/Index.js

+12 −1
Original line number Diff line number Diff line
@@ -50,7 +50,18 @@ Ext.define('Docs.view.comments.Index', { 
        this.callParent(arguments);

        this.initCookies();



        Ext.get('comment-index-container').mask();

        this.setMasked(true);

    },



    /**

     * Masks or unmasks the container

     * @param {Boolean} masked True to show mask.

     */

    setMasked: function(masked) {

        var container = Ext.get('comment-index-container');

        if (container) {

            container[masked ? "mask" : "unmask"]();

        }

    },



    /**