Commit 0745f9f0 authored by Rene Saarsoo's avatar Rene Saarsoo
Browse files

Code style fixes. 

- Added missing semicolons.
- Added and improved comments.
- Removed extra whitespace.
- Removed self-variables, which were of minimal use.
parent 7729a40a

template/app/controller/Classes.js

+2 −1
Original line number Diff line number Diff line 
/**

 * Listeners should be defined here instead of in the view classes

 * Controller responsible for loading classes, guides, and switching

 * between pages.

 */

Ext.define('Docs.controller.Classes', {

    extend: 'Ext.app.Controller',

template/app/controller/Examples.js

+19 −26
Original line number Diff line number Diff line 
/**

 * Listeners should be defined here instead of in the view classes

 * Controller for both examples tab and inline examples.

 */

Ext.define('Docs.controller.Examples', {

    extend: 'Ext.app.Controller',
@@ -12,11 +12,9 @@ Ext.define('Docs.controller.Examples', { 
    ],



    init: function() {



        this.control({

            'inlineexample': {

                afterlayout: function(cmp) {



                    if (!cmp.codeEditor) {

                        var codeBody = cmp.getComponent(0).body;
@@ -32,7 +30,7 @@ Ext.define('Docs.controller.Examples', { 
            },

            'inlineexample [cmpName=code]': {

                activate: function(cmp) {

                    this.activateTab(cmp, 'code')

                    this.activateTab(cmp, 'code');

                    var inlineEg = cmp.up('inlineexample');

                    if (inlineEg && inlineEg.codeEditor) {

                        // Weird bug on CodeMirror requires 2 refreshes...
@@ -51,7 +49,7 @@ Ext.define('Docs.controller.Examples', { 
            },

            'inlineexample [cmpName=meta]': {

                activate: function(cmp) {

                    this.activateTab(cmp, 'info')

                    this.activateTab(cmp, 'info');

                }

            },

            'inlineexample toolbar button[iconCls=code]': {
@@ -100,9 +98,6 @@ Ext.define('Docs.controller.Examples', { 
    },



    showExample: function(inlineEg, exampleId, stripComments, updateHeight) {



        var self = this;



        // Works with Gists from GitHub

        if (exampleId.match(/^https:\/\/api\.github\.com/)) {

            Ext.data.JsonP.request({
@@ -113,15 +108,13 @@ Ext.define('Docs.controller.Examples', { 
                },

                scope: this

            });



        } else {

        }

        else {

            Ext.Ajax.request({

                method: 'GET',

                url: 'doc-resources/' + exampleId,

                headers: { 'Content-Type' : 'application/json' },



                success: function(response, opts) {



                    // Remove any trailing whitespace

                    var code = response.responseText.replace(/\s*$/, '');
@@ -134,33 +127,33 @@ Ext.define('Docs.controller.Examples', { 


                    var activeItem = inlineEg.layout.getActiveItem();

                    if (activeItem.cmpName == 'preview') {

                        self.refreshPreview(inlineEg);

                        this.refreshPreview(inlineEg);

                    }



                    if (updateHeight) {

                        inlineEg.updateHeight();

                    }

                }

                },

                scope: this

            });

        }

    },



    replaceExampleDivs: function() {

        var self = this;



        Ext.Array.each(Ext.query('.inline-example'), function(inlineEg) {

            var egId = inlineEg.getAttribute('rel');

            var divId = inlineEg.getAttribute('id');

            var eg = Ext.create('Docs.view.examples.Inline', {

            Ext.create('Docs.view.examples.Inline', {

                height: 200,

                renderTo: divId,

                listeners: {

                    render: function() {

                        self.showExample(this, egId, true, true);

                    }

                    render: function(cmp) {

                        this.showExample(cmp, egId, true, true);

                    },

                    scope: this

                }

            });

        });

        }, this);

    },



    refreshPreview: function(cmp) {

template/app/controller/Search.js

+1 −1
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ Ext.define('Docs.controller.Search', { 
        }

    ],



    // Currentl page in search results and nr of items on one page

    // Current page in search results and nr of items on one page

    pageIndex: 0,

    pageSize: 10,

template/app/view/cls/Examples.js

+3 −0
Original line number Diff line number Diff line 
/**

 * Panel with grid listing all examples and an area for viewing them.

 */

Ext.define('Docs.view.cls.Examples', {

    extend: 'Ext.panel.Panel',

    alias: 'widget.classexamples',

template/app/view/cls/Overview.js

+7 −2
Original line number Diff line number Diff line
@@ -17,7 +17,13 @@ Ext.define('Docs.view.cls.Overview', { 
    bodyPadding: '20',



    initComponent: function() {

        this.addEvents('afterload');

        this.addEvents(

            /**

             * @event

             * Fired after class docs loaded panel.

             */

            'afterload'

        );

        this.callParent(arguments);

    },
@@ -48,7 +54,6 @@ Ext.define('Docs.view.cls.Overview', { 
     * @param {Object} docClass

     */

    load: function(docClass) {



        this.docClass = docClass;



        if (this.toolbar) {