Skip to content
Unverified Commit 3cdfe7b0 authored by Joas Schilling's avatar Joas Schilling
Browse files

Don't try a transaction for the migrator on MySQL

As per https://dev.mysql.com/doc/refman/8.0/en/implicit-commit.html
CREATE TABLE statements automatically commit always. The only reason
this worked in the past was that PHPs PDO connection didn't check the
actual state on commit, but only checked their internal state.
But in PHP8 this was fixed:
https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L446-L450


So now commit() fails because the internal PDO connection implicitly
commited already.

Signed-off-by: default avatarJoas Schilling <coding@schilljs.com>
parent 81302f78
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment