- Dec 10, 2016
-
-
Daniel Beck authored
-
Daniel Beck authored
[JENKINS-40281] Do not try to mutate the result of getActions(Class)
-
- Dec 09, 2016
-
-
andrealaura authored
* [FIX JENKINS-36044]: Added default locale to XMLUtilsTest so that it runs independent from the host OS locale. * [FIX JENKINS-36044]: Cleanup default-locale after test, to avoid impact to other tests. * [FIX JENKINS-36044]: Make test language indepedent. * [FIX JENKINS-36044]: Cleanup unused imports.
-
Daniel Beck authored
Annotate localizer generated Messages classes with NoExternalUse
-
Oleg Nenashev authored
Test plugin wrapper
-
Jesse Glick authored
* Make sure Security218BlackBoxTest cleans up threads it starts. * Some code simplifications, and possible leak fixes, based on CLI now being AutoCloseable. * Obsolete comment.
-
Jesse Glick authored
* Converted to JenkinsRule. * Improved messages from Node.canTake. * [FIXED JENKINS-38514] BuildableItem needs to retain information from JobOffer about why it is neither blocked nor building. * Converted to JenkinsRule. * Found an existing usage of BecauseNodeIsNotAcceptingTasks. * Original JENKINS-6598 test was checking behavior we want amended by JENKINS-38514. * Ensure that a BuildableItem which is simply waiting for a free executor reports that as its CauseOfBlockage. * Review comments from @oleg-nenashev.
-
Jesse Glick authored
-
- Dec 07, 2016
-
-
Kanstantsin Shautsou authored
UserProperty may contain nested objects that depend on User. On User reconfiguration setUser(User) is called so it should be non-final to have ability override it and update references in nested objects. Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
-
- Dec 06, 2016
-
-
Daniel Beck authored
Also update to localizer 1.24 which adds support for this.
-
- Dec 05, 2016
-
-
Daniel Beck authored
-
- Dec 04, 2016
-
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
- Dec 03, 2016
-
-
Oleg Nenashev authored
[JENKINS-23271] - Process statuses of Remote process join() operations directly inside methods (#2653) * [JENKINS-23271] - Process statuses of Remote process join() operations directly inside methods * [JENKINS-23271] - Also prevent the issue when the kill() command is the last call in the usage sequence
-
- Nov 30, 2016
-
-
Daniel Beck authored
Clarify hudson.Extension#ordinal documentation
-
Baptiste Mathus authored
I have to read it many times each time I need it. Hopefully it's a bit clearer with this addition.
-
- Nov 29, 2016
-
-
Jesse Glick authored
-
- Nov 28, 2016
-
-
Baptiste Mathus authored
Be able to specify the log Level when system property is not found
-
mawinter69 authored
-
Kohsuke Kawaguchi authored
-
- Nov 27, 2016
-
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
Daniel Beck authored
It's not actually a change in anything we deliver.
-
Oleg Nenashev authored
-
Damian Szczepanik authored
-
Oleg Nenashev authored
Update winp to 1.24. In particular, it addresses issues like [JENKINS-20913](https://issues.jenkins-ci.org/browse/JENKINS-20913) (#2619) ### Changes to be picked ### 1.24 Release date: Nov 2, 2016 * [Issue #22](https://github.com/kohsuke/winp/issues/22) - Winp sometimes kills random processes when using killRecursive. ([PR #23](https://github.com/kohsuke/winp/pull/23)) * [WINP-10](https://java.net/jira/browse/WINP-10) - Fix for `getCmdLineAndEnvVars()` which fails on x64 versions of Windows. ([PR #20](https://github.com/kohsuke/winp/pull/20)) * [Issue #24](https://github.com/kohsuke/winp/issues/24) - Wrong folder when using the `winp.folder.preferred` system property (parent instead of the actual folder). ([PR #25](https://github.com/kohsuke/winp/pull/25)) * [Issue #26](https://github.com/kohsuke/winp/issues/26), [JENKINS-20913](https://issues.jenkins-ci.org/browse/JENKINS-20913) - Native class now tries loading DLLs via the temp location. ([PR #27](https://github.com/kohsuke/winp/pull/27)) ### 1.23 Release date: Fev 16, 2015 * Migrate native components to Visual Studio Community 2013. ([PR #14](https://github.com/kohsuke/winp/pull/14)) * Provide a `winp.unpack.dll.to.parent.dir` property, which disables DLL unpacking to the parent dir. ([PR #14](https://github.com/kohsuke/winp/pull/12))
-
Oleg Nenashev authored
`the fix disables some obsolete protocols as per [JENKINS-39805](https://issues.jenkins-ci.org/browse/JENKINS-39805): AES128CBC, TripleDESCBC.Factory(), and BlowfishCBC All changes: https://github.com/jenkinsci/sshd-module/compare/sshd-1.7...sshd-1.8
-
Jesse Glick authored
* Optimize Actionable.getAllActions. * Also need to invalidate the cache when new plugins are installed. * Various improvements to TransientActionFactory caching. · Move the cache code to TransientActionFactory itself, for better encapsulation. · Optimize getAction(Class) to not need to call getAllActions; avoids copying lists, and can avoid calling TransientActionFactory at all. · Ensure that we maintain a separate cache per ExtensionList instance, so that static state is not leaked across Jenkins restarts. * Updated TransientActionFactory to specify what kinds of actions it could produce. * It turns out that changing type parameters for an extension, while generally binary-compatible, breaks reflective code in Jenkins and so this is not an option. … hudson.ExtensionFinder$GuiceFinder$SezpozModule configure WARNING: Failed to load com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl java.lang.LinkageError: Failed to resolve class com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl at hudson.ExtensionFinder$GuiceFinder$SezpozModule.resolve(ExtensionFinder.java:489) at hudson.ExtensionFinder$GuiceFinder$SezpozModule.configure(ExtensionFinder.java:506) at … at hudson.ExtensionFinder$GuiceFinder.<init>(ExtensionFinder.java:280) at … at hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:472) at hudson.ExtensionList.load(ExtensionList.java:349) at hudson.ExtensionList.ensureLoaded(ExtensionList.java:287) at hudson.ExtensionList.getComponents(ExtensionList.java:167) at jenkins.model.Jenkins$8.onInitMilestoneAttained(Jenkins.java:1082) at jenkins.InitReactorRunner$1.onAttained(InitReactorRunner.java:82) at org.jvnet.hudson.reactor.ReactorListener$Aggregator.onAttained(ReactorListener.java:104) at org.jvnet.hudson.reactor.Reactor$1.run(Reactor.java:176) at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) Caused by: java.lang.reflect.MalformedParameterizedTypeException at sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.validateConstructorArguments(ParameterizedTypeImpl.java:58) at sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.<init>(ParameterizedTypeImpl.java:51) at sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.make(ParameterizedTypeImpl.java:92) at sun.reflect.generics.factory.CoreReflectionFactory.makeParameterizedType(CoreReflectionFactory.java:105) at sun.reflect.generics.visitor.Reifier.visitClassTypeSignature(Reifier.java:140) at sun.reflect.generics.tree.ClassTypeSignature.accept(ClassTypeSignature.java:49) at sun.reflect.generics.repository.ClassRepository.getSuperclass(ClassRepository.java:90) at java.lang.Class.getGenericSuperclass(Class.java:777) at hudson.ExtensionFinder$GuiceFinder$SezpozModule.resolve(ExtensionFinder.java:470) ... 29 more * Remove actionType override to make for a simpler diff. * Strengthened test to cover accesses to unrelated context types. * Strengthening tests in a couple of ways. * Javadoc improvements suggested by @oleg-nenashev.
-
- Nov 25, 2016
-
-
Oliver Gondža authored
-
Oliver Gondža authored
-
Baptiste Mathus authored
Some properties are more important than others. One may for example want to log a WARNING instead of the current default CONFIG when some property can not be found, or has an invalid format (like a string, when asking for an Integer).
-
- Nov 22, 2016
-
-
Jesse Glick authored
-
- Nov 21, 2016
-
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
- Nov 20, 2016
-
-
Oleg Nenashev authored
-
Oleg Nenashev authored
[JENKINS-23271] - Prevent early deallocation of the Proc instance by GC in ProcStarter#join() (#2635) * [JENKINS-23271] - Prevent the prelimimary deallocation of the Proc instance by GC It is a hackish way, which likely prevents a preliminary deallocation of the spawned RemoteProc instance, which we see in JENKINS-23271. Proc instance was not actually required in the original code since we were creating and using RemoteInvocationHandler wrapper only, and the theory discussed with @stephenc was that object gets removed by Java8 garbage collector before we get into join(). This fix enforces the persistency of ProcStarter#start() result by adding logging and the enforced volatile field (maybe the last one is not really required, but JIT compiler in Java implementations may be smart enough to skip unused loggers) This is a pretty old fix from August, which has been soak tested on my instance for several weeks (mid-August => Jenkins World). On the reference instance (just a small Jenkins instance with 4 agents and very frequent builds with CommandInterpreter steps) I saw 2 failures over the period. On the fixed instance - 0. It does not proof anything, but at least the fix was soak tested a bit * [JENKINS-23271] - Get rid of the procHolderForJoin field * [JENKINS-23271] - Also put the check into the finally statement as @stephenc proposed * Remove assert
-
Daniel Beck authored
-
Daniel Beck authored
Stop storing three identical copies of remoting.jar in jenkins.war
-