Skip to content
  1. Dec 10, 2016
  2. Dec 09, 2016
  3. Dec 07, 2016
  4. Dec 06, 2016
  5. Dec 05, 2016
  6. Dec 04, 2016
  7. Dec 03, 2016
    • Oleg Nenashev's avatar
      [JENKINS-23271] - Process statuses of Remote process join() operations... · 29893354
      Oleg Nenashev authored
      [JENKINS-23271] - Process statuses of Remote process join() operations directly inside methods (#2653)
      
      * [JENKINS-23271] - Process statuses of Remote process join() operations directly inside methods
      
      * [JENKINS-23271] - Also prevent the issue when the kill() command is the last call in the usage sequence
      29893354
  8. Nov 30, 2016
  9. Nov 29, 2016
  10. Nov 28, 2016
  11. Nov 27, 2016
  12. Nov 25, 2016
  13. Nov 22, 2016
  14. Nov 21, 2016
  15. Nov 20, 2016
    • Oleg Nenashev's avatar
    • Oleg Nenashev's avatar
      [JENKINS-23271] - Prevent early deallocation of the Proc instance by GC in... · fd6c6aff
      Oleg Nenashev authored
      [JENKINS-23271] - Prevent early deallocation of the Proc instance by GC in ProcStarter#join() (#2635)
      
      * [JENKINS-23271] - Prevent the prelimimary deallocation of the Proc instance by GC
      
      It is a hackish way, which likely prevents a preliminary deallocation of the spawned RemoteProc instance, which we see in JENKINS-23271. Proc instance was not actually required in the original code since we were creating and using RemoteInvocationHandler wrapper only, and the theory discussed with @stephenc was that object gets removed by Java8 garbage collector before we get into join().
      
      This fix enforces the persistency of ProcStarter#start() result by adding logging and the enforced volatile field (maybe the last one is not really required, but JIT compiler in Java implementations may be smart enough to skip unused loggers)
      
      This is a pretty old fix from August, which has been soak tested on my instance for several weeks (mid-August => Jenkins World). On the reference instance (just a small Jenkins instance with 4 agents and very frequent builds with CommandInterpreter steps) I saw 2 failures over the period. On the fixed instance - 0. It does not proof anything, but at least the fix was soak tested a bit
      
      * [JENKINS-23271] - Get rid of the procHolderForJoin field
      
      * [JENKINS-23271] - Also put the check into the finally statement as @stephenc proposed
      
      * Remove assert
      fd6c6aff
    • Daniel Beck's avatar
    • Daniel Beck's avatar
      Merge pull request #2633 from jglick/remoting.jar · 33d38991
      Daniel Beck authored
      Stop storing three identical copies of remoting.jar in jenkins.war
      33d38991
Loading