Skip to content
  1. Jun 16, 2015
  2. Jun 15, 2015
    • Stephen Connolly's avatar
      Test case was subject to timing bugs · 10a88756
      Stephen Connolly authored
      - I suspect the synchronization on Jenkins is a bug also... but not causing the test failure, so will ignore for now
      10a88756
    • Stephen Connolly's avatar
      [FIXED JENKINS-28840] Deadlock between Queue.maintain and Executor.interrupt · 6f343dc7
      Stephen Connolly authored
      More fun here:
      
      - All this originates from Executor extending Thread.
      - There is funky logic in the lock handling code of the JVM that makes assumptions
        about how it might proceed with the lock when the thread holding the lock has its
        interrupt flag set.
      - Really it would be better if Executor did not extend Thread as that way we wouldn't
        have to deal with some of that complexity. But OTOH we are where we are and backwards
        compatibility may make such a change not possible without a lot of breakage.
      - Fixing the issue at hand, firstly requires that interrupting a Computer happens with the
        Queue lock held (to speed up tests we have Jenkins.cleanup get the lock for all Computers)
        That prevents the Queue maintain thread from getting caught
      - Secondly, when removing an executor from a computer we process the removal while
        holding the Queue lock, but we move the removal itself to a separate thread if we cannot
        get the Queue lock in order to avoid deadlock.
      - Also add helper methods to wrap tasks to be performed while holding the lock
        and a helper method for Runnables that exposes the tryLock functionality
      6f343dc7
  3. Jun 13, 2015
  4. Jun 11, 2015
  5. Jun 10, 2015
  6. Jun 09, 2015
  7. Jun 08, 2015
  8. Jun 07, 2015
  9. Jun 06, 2015
  10. Jun 05, 2015
  11. Jun 03, 2015
  12. Jun 01, 2015