- Nov 10, 2014
-
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
- Nov 08, 2014
-
-
Oliver Gondža authored
-
Oliver Gondža authored
Aggregate multiple FormValidations into one
-
- Nov 07, 2014
-
-
Oliver Gondža authored
Expose AbstractProject.AbstractProjectDescriptor#validateLabelExpression for plugins
-
Jesse Glick authored
-
Jesse Glick authored
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
IIUC, the issue here is that the request in question contains both a valid session cookie AND basic authentication header, and that path results in a failure because BasicHeaderProcessor expects one of BasicHeaderAuthenticators to validate the basic authentication header (without knowing that there's already a valid Authentication object that came from the HTTP session, yet no BasicHeaderAuthenticator actually processes this because BasicHeaderRealPasswordAuthenticator backs away from doing that. I think the corect fix is for BasicHeaderRealPasswordAuthenticator to get rid of authenticationIsRequired check. This check instead belongs to BasicHeaderProcessor, where it should be used to check if any BasicHeaderAuthenticator should be consulted or not. The problem with having this logic in BasicHeaderRealPasswordAuthenticator is that this is just an implementation of an extension point, and thus it needs to be removable. As it stands right now in this fix, if this impl is removed, JENKINS-25144 will be back again.
-
Christof Schoell authored
return authentication object instead of null if authentication is not required - otherwise valid login fails with basic authentication
-
Oleg Nenashev authored
jenkins.model.Jenkins::getInstance() method is marked as @CheckForNull, but the most of Jenkins code does not actually check the return value. It leads to tons of static analysis errors, hence it is hard to analyze the code. The change also adds annotations to old methods like Hudson::getInstance() Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
-
Oliver Gondža authored
- Nov 06, 2014
-
-
Jesse Glick authored
-
Jesse Glick authored
-
Oliver Gondža authored
-
Oliver Gondža authored
-
- Nov 05, 2014
-
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
This matches fb65a2c3c8584a9ac4daa49ecbce7a540dc7f5a5 in remoting.
-
Jesse Glick authored
Even though SezpozModule.configure catches and ignores the faulty component, Guice still dies: … hudson.ExtensionFinder$GuiceFinder <init> SEVERE: Failed to create Guice container from all the plugins com.google.inject.internal.guava.collect.$ComputationException: java.lang.NoClassDefFoundError: org/eclipse/jgit/storage/file/FileRepository at … at com.google.inject.Guice.createInjector(Guice.java:73) at hudson.ExtensionFinder$GuiceFinder.<init>(ExtensionFinder.java:279)
-
- Nov 04, 2014
-
-
Jesse Glick authored
[FIXED JENKINS-25400] Rework fix of JENKINS-22769 (c04cdcd9) to put the burden on each listener to impersonate ACL.SYSTEM if it needs to.
-
Jesse Glick authored
-
Jesse Glick authored
-
Jesse Glick authored
-
Oleg Nenashev authored
Properly close listeners for asynchronous threads. Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
-
Oleg Nenashev authored
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
-
Oleg Nenashev authored
Resource leak may happen during the search of manifest file. Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
-
Oleg Nenashev authored
The issue is related to JENKINS-18351. Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
-
Oleg Nenashev authored
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
-
Oleg Nenashev authored
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
-
Oleg Nenashev authored
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
-
- Nov 03, 2014
-
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-