Skip to content
  1. May 24, 2014
  2. May 22, 2014
  3. May 21, 2014
  4. May 20, 2014
  5. May 19, 2014
  6. May 15, 2014
  7. May 14, 2014
  8. May 13, 2014
  9. May 12, 2014
  10. May 11, 2014
  11. May 05, 2014
  12. May 04, 2014
  13. May 02, 2014
  14. May 01, 2014
  15. Apr 30, 2014
  16. Apr 29, 2014
  17. Apr 28, 2014
  18. Apr 27, 2014
  19. Apr 24, 2014
  20. Apr 21, 2014
  21. Apr 20, 2014
  22. Apr 19, 2014
    • anafke's avatar
      [FIXED JENKINS-21729] Fix IE8 NPE with respect to sortability · 6566a0c7
      anafke authored
      IE8 (and I assume other browsers that use a doctype pre-html5) interpret the span outside of the link, as in HTML4.01 you needed the closing tag.
      http://www.w3.org/TR/REC-html40/struct/global.html#h-7.5.4
      
      The code was causing a NPE in IE8 and users could not sort the columns.
      
      >> cell.innerHTML = '<a href="#" class="sortheader">'+this.getInnerText(cell)+'<span class="sortarrow" /></a>';
      
      >> cell.innerHTML ;
      "<A class=sortheader href="#"> S<SPAN class=sortarrow></A></SPAN>"
      
      >> cell.innerHTML = '<a href="#" class="sortheader">'+this.getInnerText(cell)+'<span class="sortarrow"></span></a>'
      
      >> cell.innerHTML ;
      "<A class=sortheader href="#"> S<SPAN class=sortarrow></SPAN></A>"
      6566a0c7
Loading