Skip to content
  1. May 13, 2016
  2. May 12, 2016
  3. May 11, 2016
  4. May 10, 2016
    • Oliver Gondža's avatar
      59c86b8f
    • Oleg Nenashev's avatar
      Merge pull request #2319 from oleg-nenashev/JENKINS-34674 · 0b3dbfce
      Oleg Nenashev authored
      [JENKINS-34674,JENKINS-34675] - Handling of the default update site ID
      0b3dbfce
    • Baptiste Mathus's avatar
      Switch Jenkins.getInstance() to @Nonnull (#2297) · b9bb52ff
      Baptiste Mathus authored
      As detailed by @stephenc:
      
      > So there is `getInstanceOrNull()` which is for use in Jenkins core or
      > in code that plugins add that may escape the Jenkins singleton
      > lifecycle.
      >
      > In regular plugins `getInstance()` will never return null as the
      > lifecycle does not instantiate them until after there is a Jenkins
      > singleton and the plugins will be stopped before there is no
      > singleton.
      >
      > The `getActiveInstance()` is therefore equivalent to `getInstance()`
      > and should never have been born.
      >
      > The only way a plugin can get a `null` from `Jenkins.getInstance()` is
      > if you install an `atExit()` handler, use a `PhantomReference` type
      > thing, or directly manipulate the servlet container in some way or
      > other. A correctly written plugin should unwind any of those things
      > when it is stopped or a method bound to the termination lifecycle. If
      > there are some cases (for which I cannot anticipate a good coder being
      > able to write a correct termination lifecycle method to fix) where the
      > code cannot be unhooked... then in those cases the plugin should use
      > `getInstanceOrNull()` and know how to respond to the `null` that could
      > not be avoided.
      b9bb52ff
  5. May 09, 2016
Loading