Skip to content
  1. Dec 04, 2011
    • Christoph Kutzinski's avatar
      - removed unused method · 3bb6f4ef
      Christoph Kutzinski authored
      - doc update
      3bb6f4ef
    • Christoph Kutzinski's avatar
      Merge pull request #323 from davidmc24/master · 1fe71dd8
      Christoph Kutzinski authored
      Don't call SCM#calcPollingingBaseline if SCM#checkout fails
      1fe71dd8
    • David M. Carr's avatar
      Don't call SCM#calcPollingingBaseline if SCM#checkout fails · 70fb68ee
      David M. Carr authored
      In the JavaDocs for SCM#calcRevisionsFromBuild, if says:
      This method is called after source code is checked out for the given build (that is, after SCM#checkout has finished successfully.)
      
      This appears to make sense; after you have a known SCM state, you calculate the revisions.  It doesn't explicitly state it, but it
      implies that it won't be called if checkout failed.  In those cases, the state may well not be known, and it doesn't make sense to
      attempt to calculate the revisions.
      
      The behavior in AbstractProject#checkout has been to always call calcPollingBaseline, regardless of whether checkout failed or
      succeeded.  This is causing misleading error output for the mercurial plugin.  With this change, AbstractProject will only do the
      calculations when checkout succeeds.
      70fb68ee
  2. Dec 03, 2011
  3. Dec 02, 2011
Loading