Skip to content
  1. Aug 20, 2012
  2. Aug 09, 2012
  3. Aug 07, 2012
  4. Aug 06, 2012
  5. Aug 04, 2012
  6. Aug 03, 2012
    • Jesse Glick's avatar
      [FIXED JENKINS-14495] Hetero lists not working correctly after adding elements. · dbb100da
      Jesse Glick authored
      Unlike [JENKINS-14514] this is a true fix rather than a workaround (now removed), and is more general.
      cjo9900 discovered that behaviors were being redundantly registered (as of 1.474 the monolithic JS is broken up);
      this caused some behaviors to be run repeatedly on the same elements, breaking reasonable expectations of some behaviors.
      The ideal fix would be to change Behavior.register to be idempotent: for example, key it by selector, then maintain a set of distinct behavior functions for each.
      Unfortunately some adjuncts directly call Behavior.list.unshift, bypassing register(...), which would be tricky to intercept (would need to make a mock of Array).
      The known one cases are in core, but it is possible plugin adjuncts do this too, in which case it would be incompatible to (say) change the Array<Map<String,Behavior>> to a Map<String,Array<Behavior>>.
      Instead, permitting redundant registrations as before, and just silently skipping all but the first at runtime when applying behaviors.
      Beware that since adjuncts are loaded from multiple places, different JS function objects are registered each time, so a naive set of behavior functions does not work;
      have to identify functions by their toString in order to ensure that each is run only once.
      (Currently once _per selector_, conceivably >1x per element; could if necessary be refined to make sure a given behavior is only run once on a given element during one call to applySubtree even if the element matches multiple selectors.)
      dbb100da
  7. Aug 02, 2012
  8. Jul 31, 2012
  9. Jul 26, 2012
  10. Jul 25, 2012
  11. Jul 24, 2012
  12. Jul 23, 2012
  13. Jul 19, 2012
  14. Jul 11, 2012
  15. Jul 10, 2012
  16. Jul 06, 2012
  17. Jul 05, 2012
    • Jesse Glick's avatar
      [FIXED JENKINS-14325] CCE & missing GUI when using jobs inside folders. · c91584ff
      Jesse Glick authored
      Introduced AbstractProject.supportsMakeDisabled rather than using trick of checking for parent instanceof Jenkins.
      Extracted common GUI into makeDisabled.jelly, with accompanying I18N refactoring.
      Also moved all this into AbstractProject, where the relevant methods are defined, rather than Job where they are not.
      c91584ff
  18. Jul 02, 2012
  19. Jun 28, 2012
  20. Jun 25, 2012
  21. Jun 24, 2012
Loading