Skip to content
  1. Feb 17, 2012
  2. Feb 16, 2012
  3. Feb 15, 2012
  4. Feb 14, 2012
  5. Feb 13, 2012
  6. Feb 10, 2012
    • Kohsuke Kawaguchi's avatar
      [FIXED JENKINS-12334 JENKINS-12446 JENKINS-12650] · ef1ad6ca
      Kohsuke Kawaguchi authored
      Bundle slf4j binding to the war.
      See the comment in war/pom.xml for detailed discussion.
      
      This is fundamentally a "damned if I do, damned if I don't" situation,
      but given that JENKINS-12334 is a fatal error, and the downside of
      bundling the binding jar is "multiple binding" warning, it seems like
      the lesser evil is to bundle it and risk some warnings.
      ef1ad6ca
    • Kohsuke Kawaguchi's avatar
      83ad02d9
    • Kohsuke Kawaguchi's avatar
      added doc · 61ec0fc6
      Kohsuke Kawaguchi authored
      61ec0fc6
    • Kohsuke Kawaguchi's avatar
      Revisited the way Guice creates an injector during unit test · a71d037b
      Kohsuke Kawaguchi authored
      The motivation of this is to enable test code to inject components from Jenkins, which means we need a single Injector that can see all of those, including @TestExtension and regular @Extension. Then I realized that the current implementation is broken, as it creates two independent Injectors. This has other undesirable side effects like @TestExtension components not being able to inject @Extensions, etc.
      
      I briefly experimented with hierarchical Injectors (where we first create Injector that loads @Extension then create another that loads @TestExtension as a child), but this was hard to get right as we have no control over which ExtensionFinder gets instantiated first --- we'd be at the mercy of SezPoz.
      
      So the eventual approach is to allow a single GuiceFinder to recognize multiple annotations. This also works well with our using child injector for installing plugins without restart
      a71d037b
  7. Feb 09, 2012
  8. Feb 08, 2012
Loading