* [JENKINS-37857] Prompt user whether to add the job to the current view

* [JENKINS-37857] Fix review items from @daniel-beck

* [FIXED JENKINS-37731] Change symbol and constructor for SCMTrigger.

Using "scm" as the @Symbol led to collisions with the "scm" global
variable in Pipeline, so that had to go. Changed it to "pollScm". Also
moved the @DataBoundConstructor to the single-parameter constructor,
deprecated the two-parameter constructor, created a @DataBoundSetter
for ignorePostCommitHooks, and added a getter for "scmpoll_spec" to
fix snippet generator and general syntactic goodness.

So now, with this, it's possible to do:

properties([
  pipelineTriggers([
    pollScm('@daily')
  ])
])

Tada.

Tests for the snippet generator and job property stuff will be landing
in a separate PR for workflow-multibranch.

* Review comments.

* Updating @since to 2.22

For example when Descriptor was defined as field and without @Extension .

Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>

Use the appropriate 'Gear' icon on the Plugin Manager page

Fix groovy test class declaration

This has annoyed me for long enough

Fixes JENKINS-34250

Summary of changes:

* [JENKINS-36420](https://issues.jenkins-ci.org/browse/JENKINS-36420) - Allow setting up the the client idle timeout
* Upgrade to the new parent POM
* FindBugs cleanup, in particular https://github.com/jenkinsci/sshd-module/commit/66162e707189e6bda5708cf856e71b6130160cc1

* [JENKINS-37874] - Log SEVERE messages if Jenkins does not reach COMPLETED stage during startup or reload

* [JENKINS-37874] - Add Administrative monitor for the COMPLETED state

* [JENKINS-37874] - Polish log messages

* make the icon of the script console configurable

* we don't need an extra variable

* use <j:choose>

* remove restriction to be able to ovverride the method in subclasses

* since needs to be adjusted

Add newline after the text in userContent/readme.txt

Hard to see anything with Gray background and White Text.
Style is in line with Selects and other form inputs.

* [JENKINS-36748] Add a test case and not process null specs

* [JENKINS-36748] Correct license and add a minor comment

* [JENKINS-36748] Add a Waning logger when spec is null

[FIXED JENKINS-36537] Allow the use of custom json signature validator for metadata signature check (#2442)

* JENKINS-33374 - correct restart behavior during setup wizard

* Add tests

* One more test

* Test Windows junctions before Java 7 symlink

Apparently Java 7 (and later) do not count Windows junctions as
symlinks.  When you drill down into the BasicFileAttributes structure,
reparse points are only counted under isOther.  So, since we already
have code that properly detects Windows Junctions, let's use that first
and then fallback to the Java 7 code.

* Add comment for change & link bug.

* Add test case

* Switch to Functions.isWindows().

* Use non-deprecated APIs for tmp file/dir mgmt

* Add better debugging.

* Allow spaces in junction name & dir name.

To do that, it was easier to use ProcessBuilder vs building up the correct
string in code to send to cmd.exe.

Also, I'll note that according to http://ss64.com/nt/syntax-internal.html,
mklink is in internal cmd.exe command.  So, it must be invoked through
"cmd.exe /c" for it to work.

* Remove comment mentioning bug number.

* Remove debugging output, per Baptiste's request

* Add newline at end of file.

* Make sure that the junction was removed.

* Use assertEquals to show retcode of Process.waitFor.

* Fix compilation errors by importing functions