Skip to content
  1. Apr 16, 2013
    • Kohsuke Kawaguchi's avatar
      [JENKINS-13995] · 084da443
      Kohsuke Kawaguchi authored
      Added logging more liberally, and fixed the problem.
      The root cause was that when the mouse enters a hot spot, I wasn't cancelling the previous delayed hide timer.
      
      This fix eliminates the need for the hack in the hide method where I was testing if the mouse was still over the hotspot.
      084da443
    • Jesse Glick's avatar
      [JENKINS-17637] Noting. · 293403f3
      Jesse Glick authored
      293403f3
  2. Apr 15, 2013
  3. Apr 13, 2013
  4. Apr 12, 2013
  5. Apr 11, 2013
  6. Apr 10, 2013
    • Jesse Glick's avatar
      [FIXED JENKINS-15340] Ask for confirmation before reloading config from disk,... · 9eb69772
      Jesse Glick authored
      [FIXED JENKINS-15340] Ask for confirmation before reloading config from disk, as it may be expensive.
      First of all, /reload should require POST (also prevents XSS DoS attacks).
      Adding <l:confirmationLink> to encapsulate a link that requires confirmation upon clicking.
      Allowing a ManagementLink to request confirmation (also implying POST); could be used also for e.g. /quietDown.
      Enhancing <l:task> to support confirmation as well, and honoring this in context menu items.
      9eb69772
  7. Apr 09, 2013
  8. Apr 08, 2013
  9. Apr 07, 2013
  10. Apr 06, 2013
  11. Apr 04, 2013
  12. Apr 03, 2013
  13. Apr 02, 2013
  14. Mar 28, 2013
  15. Mar 26, 2013
  16. Mar 25, 2013
    • Kohsuke Kawaguchi's avatar
      creating an RC branch · ec1f5138
      Kohsuke Kawaguchi authored
      ec1f5138
    • Kohsuke Kawaguchi's avatar
      recording the fix · cb8ba8cc
      Kohsuke Kawaguchi authored
      cb8ba8cc
    • Kohsuke Kawaguchi's avatar
      [FIXED JENKINS-7291] Permit flyweight tasks to run on master even when it has... · a114c693
      Kohsuke Kawaguchi authored
      [FIXED JENKINS-7291] Permit flyweight tasks to run on master even when it has zero configured executors.
      
      Always adding Computer for master as a fallback
      
      The original proposed fix for JENKINS-7291 creates a Computer object
      transitively. This seems unwise as it violates the design of Computer
      as stated in the javadoc, and for example we can end up creating two
      Computers for the master.
      
      I think a better fix is to create a Computer for the master all the
      time, even if there's no executors configured. The discrimination in
      Queue.makeBuildable would ensure that such phantom Computer is only used
      as a last resort (statistically speaking).
      
      I've also tweaked executors.jelly a bit. I simplified it somewhat
      based on the idea that "if there's only one computer to show, the
      context is likely making it obvious".
      
      (I must be missing the intricacy in the current code.)
      
      Originally developed in a branch at
      2c5b57fcc1f39ed39057254e802f4183db5aa0dc then squashed for clarity.
      a114c693
    • Kohsuke Kawaguchi's avatar
      recording JENKINS-17311 · c4760b47
      Kohsuke Kawaguchi authored
      c4760b47
    • Kohsuke Kawaguchi's avatar
      creating an RC branch · 21f25109
      Kohsuke Kawaguchi authored
      21f25109
    • Kohsuke Kawaguchi's avatar
      updated changelog for release · 8c391449
      Kohsuke Kawaguchi authored
      8c391449
  17. Mar 23, 2013
  18. Mar 22, 2013
  19. Mar 21, 2013
    • Jesse Glick's avatar
      [FIXED JENKINS-13154] AnnotationMapper bug was causing massive lock contention... · fdc090a3
      Jesse Glick authored
      [FIXED JENKINS-13154] AnnotationMapper bug was causing massive lock contention when saving fingerprints.
      fdc090a3
    • Kohsuke Kawaguchi's avatar
      [FIXED JENKINS-7813] · 8a3e909d
      Kohsuke Kawaguchi authored
      Fixed the throughput problem between master/slave communication.
      This fix contains two independent problems.
      
      One was in the remoting. During a large sustained data transfer
      (such as artifact archiving and large test reports), the way we
      were doing flow control and ACK-ing were penalizing us badly.
      I improved the flow control algorithm in remoting 1.23, and also
      increased advertised window size so that the transfer can saturate
      available bandwidth even when a latency is large. (And unless
      the reader side is excessivesly slow, this shouldn't increase
      any memory consumption.)
      
      The other fix was in trilead-ssh2, which is our SSH client
      implementation used by ssh-slaves plugin. The buffer size for flow
      control was too small. I improved the way buffering is done to reduce
      the memory footprint when the reader closely follows the writer, then I
      increased the advertised window size. Again, this shouldn't increase
      memory consumption (in fact it'll likely actually reduce them) unless
      the reader end gets abandoned.
      
      On my simulated latency-injected network, the sustained transfer rate is
      now on par with scp. We win for smaller files because of the TCP slow
      start penality that scp would incur, and we lose a bit as files get
      larger due to additional framing overhead.
      
      If you have manually extracted slave.jar and placed them on slaves, you
      need to update them to 2.23 to see the performance benefits.
      8a3e909d
Loading