- Jun 11, 2014
-
-
Daniel Beck authored
-
- Jun 10, 2014
-
-
CloudBees DEV@Cloud authored
-
Daniel Beck authored
-
Jesse Glick authored
-
Jesse Glick authored
[FIXED JENKINS-20327] When saving a list view, submit POST data with size proportional to the # of jobs selected for inclusion, not the number of options. This can be done easily by setting json="true"; otherwise the default is to pass =false for each unselected job. Ironically, even with this fix we are sending 2× what is needed, since currently ListView.submit does not even check the json parameter for job names: it only pays attention to top-level request parameters that the browser defines for selected checkboxes. Ideally we could ask buildFormTree to ignore a given form element entirely, so as to avoid the wasted data.
-
Jesse Glick authored
-
Jesse Glick authored
[JENKINS-19310] Unreproducible failure of DirectlyModifiableViewTest.failWebMethodForIllegalRequest, probably from a StackOverflowError. at … at hudson.model.View.toString(View.java:514) at java.text.MessageFormat.subformat(MessageFormat.java:1246) at java.text.MessageFormat.format(MessageFormat.java:836) at java.text.Format.format(Format.java:140) at java.text.MessageFormat.format(MessageFormat.java:812) at java.util.logging.Formatter.formatMessage(Formatter.java:130) at java.util.logging.SimpleFormatter.format(SimpleFormatter.java:63) at java.util.logging.StreamHandler.publish(StreamHandler.java:179) at java.util.logging.ConsoleHandler.publish(ConsoleHandler.java:88) at java.util.logging.Logger.log(Logger.java:481) at java.util.logging.Logger.doLog(Logger.java:503) at java.util.logging.Logger.log(Logger.java:567) at hudson.model.AbstractItem.getUrl(AbstractItem.java:423) at hudson.model.View.getViewUrl(View.java:510) at hudson.model.View.toString(View.java:514) at …
-
CloudBees DEV@Cloud authored
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
CloudBees DEV@Cloud authored
-
Jesse Glick authored
The basic fix is to use ${rootURL} plus full model object URLs rather than relying on ${jobBaseUrl}. This is made trickier by the fact that the model object URLs are computed inside ProgressiveRendering.compute, and therefore will not be correct when nondefault views are in the crumb trail unless the original request information is present. So modifying ProgressiveRendering to preserve a copy of the original request for use during computation. (This could probably be used to simplify parts of AsynchPeople as well.) Also improving AbstractItem.getUrl to properly construct a URL including views even when the current page is not inside the item; it should suffice for some ancestor of the current item (or a view thereof) to be in the ancestor list of this page.
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
- Jun 09, 2014
-
-
Jesse Glick authored
-
Jesse Glick authored
Corrects 9ce6b0fe.
-
Jesse Glick authored
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
Jesse Glick authored
-
Jesse Glick authored
-
Jesse Glick authored
-
Jesse Glick authored
Existing code referring to a member of type AbstractBuild often called methods not present in Run. Changed to retain the existing fields and getters but deprecating them and introducing replacements.
-
Jesse Glick authored
Fix of JENKINS-8408 broke some tests of workspace-based polling; disable the fix when inside a test, for better predictability. (Ideally Jenkins would actually detect whether there was a *plan* to connect a slave of a given name.)
-
Jesse Glick authored
-
Jesse Glick authored
-
- Jun 08, 2014
-
-
Kohsuke Kawaguchi authored
Documented this feature and integrated a newer version of Stapler. I took the opportunity to reorder the content in the section, so that the tree parameter becomes the main subject. At this point, the depth parameter should be only used in a limited circumstance, so it should be treated as such.
-
- Jun 07, 2014
-
-
Kohsuke Kawaguchi authored
I came into this use case while working on the workflow, but I think it's useful in other context as well, such as Scriptler plugin needing to define some parameters.
-
Kohsuke Kawaguchi authored
-
Kohsuke Kawaguchi authored
-
Jesse Glick authored
-
Jesse Glick authored
-
- Jun 06, 2014
-
-
Harald Albers authored
-
Jesse Glick authored
-
Jesse Glick authored
-
Jesse Glick authored
-
Jesse Glick authored
Make sure the RepositoryBrowser is associated with a ChangeLogSet so we do not need to go back through the build and SCM to find it.
-