Commit efade111 authored by Nick Poulden's avatar Nick Poulden
Browse files

Comment fixes

parent 1477d30b

template/app/controller/Comments.js

+1 −2
Original line number Diff line number Diff line
@@ -82,7 +82,7 @@ Ext.define('Docs.controller.Comments', { 


            'hovermenu': {

                viewready : function(cmp) {

                    Docs.view.Comments.renderHoverMenuMeta(cmp.el)

                    Docs.view.Comments.renderHoverMenuMeta(cmp.el);

                }

            }

        });
@@ -311,7 +311,6 @@ Ext.define('Docs.controller.Comments', { 


    toggleNewComment: function(cmp, el) {

        if (!this.loggedIn) {

            this.getAuthentication().showLogin();

            return;

        }

template/app/view/Comments.js

+12 −12
Original line number Diff line number Diff line
@@ -161,6 +161,7 @@ Ext.define('Docs.view.Comments', { 


            var memberId = a.getAttribute('href').replace(/^.*\//, ''),

                memberEl = Ext.get(a).up('.member'),

                definedCls = memberEl.down('.meta a.definedIn').getAttribute('rel'),

                descriptionEl = memberEl.down('.long'),

                id = ('class-' + memberId).replace(/\./g, '-');
@@ -173,16 +174,8 @@ Ext.define('Docs.view.Comments', { 
                num: commentsMeta[memberId] || 0,

                id: id

            });

            Docs.App.getController('Comments').commentIdMap['comments-' + id] = ['class', clsName, memberEl.getAttribute('id')];



            // var hoverMember = Ext.query('.hover-menu a[rel="' + memberId + '"]')

            // console.log(hoverMember); //'.hover-menu a[rel="' + memberId + '"]')



            // // Add to hover menu too

            // var hoverMember = Ext.query('.hover-menu a[rel="' + row.key[1] + '-' + row.key[2] + '-' + row.key[3] + '"]');

            // if (hoverMember && hoverMember[0]) {

            //     this.memberCommentsTpl.append(hoverMember[0], [row.value.num]);

            // }

            Docs.App.getController('Comments').commentIdMap['comments-' + id] = ['class', definedCls, memberEl.getAttribute('id')];



        }, this);

    },
@@ -192,10 +185,17 @@ Ext.define('Docs.view.Comments', { 
        var commentsMeta = Docs.App.getController('Comments').commentMeta;



        Ext.Array.each(cmp.query('a.docClass'), function(a) {

            var memberId = a.getAttribute('rel');

            var rel = Ext.get(a.getAttribute('rel').replace(/^([^-]+\-)/, ''));



            if (rel) {

                var docClass = rel.down('.meta a.docClass'),

                    clsName = docClass.getAttribute('rel'),

                    memberId = clsName + '-' + rel;



                if (commentsMeta[memberId]) {

                    this.memberCommentsTpl.append(a, [commentsMeta[memberId] || 0]);

                }

            }

        }, this);

    },