Commit eae08656 authored by Rene Saarsoo's avatar Rene Saarsoo
Browse files

Swap miniphone landscape and portrait styles. 

The default 'landscape' now default to a view where the phone is in
portrait orientation, but because the screen is cut in half, the
resolution is actually a landscape.

Most importantly it allows us to simply write @example miniphone,
instead of having to write @example miniphone portrait - the default
landscape orientation is now the thing that one needs 99% of time.
parent 6e4965a3

lib/jsduck/logger.rb

+2 −2
Original line number Diff line number Diff line
@@ -28,9 +28,9 @@ module JsDuck 
    #

    # Optionally filename and line number will be inserted to message.

    def warn(msg, filename=nil, line=0)

      msg = filename ? "#{filename} line #{line} #{msg}" : msg

      msg = filename ? "#{filename}:#{line}: #{msg}" : msg

      if @warnings && !@shown_warnings[msg]

        $stderr.puts "Warning: " + msg

        $stderr.puts msg

        @shown_warnings[msg] = true

      end

    end

template/app/view/examples/Device.js

+1 −1
Original line number Diff line number Diff line
@@ -69,7 +69,7 @@ Ext.define('Docs.view.examples.Device', { 
        // device dimensions in landscape orientation

        var landscape = {

            phone: {width: '481px', height: '320px'},

            miniphone: {width: '219px', height: '320px'},

            miniphone: {width: '320px', height: '219px'},

            tablet: {width: '717px', height: '538px'}

        }[this.device];

template/resources/sass/viewport.scss

+6 −6
Original line number Diff line number Diff line
@@ -1236,17 +1236,17 @@ p.screenshot { 
  background: url(../images/iphone-p.jpg) no-repeat; }



.miniphone.landscape {

  padding: 22px 6px 26px 127px;

  width: 350px;

  height: 368px;

  background: url(../images/iphone-small-l.jpg) no-repeat; }



.miniphone.portrait {

  padding: 127px 22px 6px 26px;

  width: 368px;

  height: 350px;

  background: url(../images/iphone-small-p.jpg) no-repeat; }



.miniphone.portrait {

  padding: 22px 6px 26px 127px;

  width: 350px;

  height: 368px;

  background: url(../images/iphone-small-l.jpg) no-repeat; }



.example-container {

  h1 {

    padding: 15px 0 !important; } }