From e32d292a2d7017074b96682b4369704da0864fc1 Mon Sep 17 00:00:00 2001 From: Rene Saarsoo Date: Mon, 6 Jun 2011 16:55:48 +0300 Subject: [PATCH] Moved overview tab creation to Classes controller. No more passing the docClass config option to TabPanel and Overview - it's not used anyway. --- template/app/controller/Classes.js | 13 +++++++++---- template/app/view/cls/Container.js | 1 - template/app/view/cls/TabPanel.js | 11 +---------- 3 files changed, 10 insertions(+), 15 deletions(-) diff --git a/template/app/controller/Classes.js b/template/app/controller/Classes.js index 478c447f..4ee62500 100644 --- a/template/app/controller/Classes.js +++ b/template/app/controller/Classes.js @@ -6,7 +6,8 @@ Ext.define('Docs.controller.Classes', { requires: [ 'Docs.History', - 'Docs.Syntax' + 'Docs.Syntax', + 'Docs.view.cls.Overview' ], stores: [ @@ -164,12 +165,16 @@ Ext.define('Docs.controller.Classes', { classOverview = classCnt.down('classoverview'); classHeader.load(cls); - classOverview.load(cls); - if (this.getTabPanel()) { + // Init overview tab if not already available + if (!classOverview) { + classOverview = Ext.create('Docs.view.cls.Overview'); + this.getTabPanel().add(classOverview); this.getTabPanel().setActiveTab(0); - this.getTabPanel().setLoading(false); } + classOverview.load(cls); + + this.getTabPanel().setLoading(false); this.getTree().selectClass(cls.name); this.fireEvent('showClass', cls.name); diff --git a/template/app/view/cls/Container.js b/template/app/view/cls/Container.js index cae2c745..9ae3f205 100644 --- a/template/app/view/cls/Container.js +++ b/template/app/view/cls/Container.js @@ -19,7 +19,6 @@ Ext.define('Docs.view.cls.Container', { this.items = [ Ext.create('Docs.view.cls.Header'), Ext.create('Docs.view.cls.TabPanel', { - docClass: this.docClass, flex: 1 }) ]; diff --git a/template/app/view/cls/TabPanel.js b/template/app/view/cls/TabPanel.js index 6ce54ec0..316a494d 100644 --- a/template/app/view/cls/TabPanel.js +++ b/template/app/view/cls/TabPanel.js @@ -21,15 +21,6 @@ Ext.define('Docs.view.cls.TabPanel', { newCard.body.scrollTo('top', newCard.prevScroll); } } - }, - - initComponent: function() { - this.items = [ - Ext.create('Docs.view.cls.Overview', { - docClass: this.docClass - }) - ]; - - this.callParent(arguments); } + }); -- GitLab