From 1c0ebc0ad5c00ab53db61beb72928944e7882096 Mon Sep 17 00:00:00 2001
From: Rene Saarsoo <nene@triin.net>
Date: Thu, 4 Aug 2011 14:11:51 +0300
Subject: [PATCH] Refactor requires and use of XTemplate.

- Removed needless required classes from Viewport.
- videos/guides/examples Index classes now require their own List.
- Not using Ext.create('Ext.XTemplate') at class definition time.
---
 template/app/view/Viewport.js       | 17 +++----
 template/app/view/examples/Index.js |  3 ++
 template/app/view/examples/List.js  | 72 ++++++++++++++---------------
 template/app/view/guides/Index.js   |  3 ++
 template/app/view/guides/List.js    | 40 ++++++++--------
 template/app/view/videos/Index.js   |  3 ++
 template/app/view/videos/List.js    | 42 ++++++++---------
 7 files changed, 92 insertions(+), 88 deletions(-)

diff --git a/template/app/view/Viewport.js b/template/app/view/Viewport.js
index b73ba412..4d807559 100644
--- a/template/app/view/Viewport.js
+++ b/template/app/view/Viewport.js
@@ -4,22 +4,17 @@
 Ext.define('Docs.view.Viewport', {
     extend: 'Ext.container.Viewport',
     requires: [
+        'Docs.view.search.Container',
+        'Docs.view.Tabs',
+        'Docs.view.index.Welcome',
         'Docs.view.cls.Index',
         'Docs.view.cls.Container',
         'Docs.view.tree.Tree',
-        'Docs.view.index.Welcome',
+        'Docs.view.guides.Index',
+        'Docs.view.videos.Index',
         'Docs.view.videos.Tree',
         'Docs.view.examples.Index',
-        'Docs.view.examples.List',
-        'Docs.view.examples.Tree',
-        'Docs.view.FavoritesPanel',
-        'Docs.view.videos.Index',
-        'Docs.view.guides.Index',
-        'Docs.view.Tabs',
-        'Docs.view.search.Container',
-        'Docs.Favorites',
-        'Docs.Settings',
-        'Docs.History'
+        'Docs.view.examples.Tree'
     ],
 
     id: 'viewport',
diff --git a/template/app/view/examples/Index.js b/template/app/view/examples/Index.js
index c42fa0f3..bd83d7fe 100644
--- a/template/app/view/examples/Index.js
+++ b/template/app/view/examples/Index.js
@@ -4,6 +4,9 @@
 Ext.define('Docs.view.examples.Index', {
     extend: 'Ext.container.Container',
     alias: 'widget.examplesindex',
+    requires: [
+        'Docs.view.examples.List'
+    ],
 
     cls: 'all-demos iScroll',
     margin: '10 0 0 0',
diff --git a/template/app/view/examples/List.js b/template/app/view/examples/List.js
index 02b24be9..1f751681 100644
--- a/template/app/view/examples/List.js
+++ b/template/app/view/examples/List.js
@@ -8,42 +8,6 @@ Ext.define('Docs.view.examples.List', {
     cls: 'demos',
     itemSelector: 'dl',
 
-    tpl: Ext.create('Ext.XTemplate',
-        '<div id="sample-ct">',
-            '<tpl for=".">',
-            '<div><a name="{id}"></a><h2><div>{title}</div></h2>',
-            '<dl>',
-                '<tpl for="samples">',
-                    '<dd ext:url="{url}"><img src="extjs/examples/shared/screens/{icon}"/>',
-                        '<div><h4>{text}',
-                            '<tpl if="this.isNew(values.status)">',
-                                '<span class="new-sample"> (New)</span>',
-                            '</tpl>',
-                            '<tpl if="this.isUpdated(values.status)">',
-                                '<span class="updated-sample"> (Updated)</span>',
-                            '</tpl>',
-                            '<tpl if="this.isExperimental(values.status)">',
-                                '<span class="new-sample"> (Experimental)</span>',
-                            '</tpl>',
-                        '</h4><p>{desc}</p></div>',
-                    '</dd>',
-                '</tpl>',
-            '<div style="clear:left"></div></dl></div>',
-            '</tpl>',
-        '</div>',
-        {
-            isExperimental: function(status) {
-                return status === 'experimental';
-            },
-            isNew: function(status) {
-                return status === 'new';
-            },
-            isUpdated: function(status) {
-                return status === 'updated';
-            }
-        }
-    ),
-
     initComponent: function() {
         this.addEvents(
             /**
@@ -54,6 +18,42 @@ Ext.define('Docs.view.examples.List', {
             'exampleclick'
         );
 
+        this.tpl = Ext.create('Ext.XTemplate',
+            '<div id="sample-ct">',
+                '<tpl for=".">',
+                '<div><a name="{id}"></a><h2><div>{title}</div></h2>',
+                '<dl>',
+                    '<tpl for="samples">',
+                        '<dd ext:url="{url}"><img src="extjs/examples/shared/screens/{icon}"/>',
+                            '<div><h4>{text}',
+                                '<tpl if="this.isNew(values.status)">',
+                                    '<span class="new-sample"> (New)</span>',
+                                '</tpl>',
+                                '<tpl if="this.isUpdated(values.status)">',
+                                    '<span class="updated-sample"> (Updated)</span>',
+                                '</tpl>',
+                                '<tpl if="this.isExperimental(values.status)">',
+                                    '<span class="new-sample"> (Experimental)</span>',
+                                '</tpl>',
+                            '</h4><p>{desc}</p></div>',
+                        '</dd>',
+                    '</tpl>',
+                '<div style="clear:left"></div></dl></div>',
+                '</tpl>',
+            '</div>',
+            {
+                isExperimental: function(status) {
+                    return status === 'experimental';
+                },
+                isNew: function(status) {
+                    return status === 'new';
+                },
+                isUpdated: function(status) {
+                    return status === 'updated';
+                }
+            }
+        );
+
         this.on({
             'afterrender': function(cmp) {
                 cmp.el.addListener('mouseover', function(evt, el) {
diff --git a/template/app/view/guides/Index.js b/template/app/view/guides/Index.js
index ab276612..33ed0f55 100644
--- a/template/app/view/guides/Index.js
+++ b/template/app/view/guides/Index.js
@@ -4,6 +4,9 @@
 Ext.define('Docs.view.guides.Index', {
     extend: 'Ext.container.Container',
     alias: 'widget.guideindex',
+    requires: [
+        'Docs.view.guides.List'
+    ],
 
     cls: 'all-demos iScroll',
     margin: '10 0 0 0',
diff --git a/template/app/view/guides/List.js b/template/app/view/guides/List.js
index db6d1d92..504f3c71 100644
--- a/template/app/view/guides/List.js
+++ b/template/app/view/guides/List.js
@@ -8,26 +8,6 @@ Ext.define('Docs.view.guides.List', {
     cls: 'demos',
     itemSelector: 'dl',
 
-    tpl: Ext.create('Ext.XTemplate',
-        '<div id="sample-ct">',
-            '<tpl for=".">',
-            '<div><a name="{url}"></a><h2><div>{group}</div></h2>',
-            '<dl>',
-                '<tpl for="guides">',
-                    '<dd ext:url="guide/{name}"><img src="guides/{name}/icon-lg.png"/>',
-                        '<div><h4>{title}</h4><p>{description}</p></div>',
-                    '</dd>',
-                '</tpl>',
-            '<div style="clear:left"></div></dl></div>',
-            '</tpl>',
-        '</div>',
-        {
-            isExperimental: function(status) {
-                return status === 'experimental';
-            }
-        }
-    ),
-
     initComponent: function() {
         this.addEvents(
             /**
@@ -38,6 +18,26 @@ Ext.define('Docs.view.guides.List', {
             'guideclick'
         );
 
+        this.tpl = Ext.create('Ext.XTemplate',
+            '<div id="sample-ct">',
+                '<tpl for=".">',
+                '<div><a name="{url}"></a><h2><div>{group}</div></h2>',
+                '<dl>',
+                    '<tpl for="guides">',
+                        '<dd ext:url="guide/{name}"><img src="guides/{name}/icon-lg.png"/>',
+                            '<div><h4>{title}</h4><p>{description}</p></div>',
+                        '</dd>',
+                    '</tpl>',
+                '<div style="clear:left"></div></dl></div>',
+                '</tpl>',
+            '</div>',
+            {
+                isExperimental: function(status) {
+                    return status === 'experimental';
+                }
+            }
+        );
+
         this.on({
             'afterrender': function(cmp) {
                 cmp.el.addListener('mouseover', function(evt, el) {
diff --git a/template/app/view/videos/Index.js b/template/app/view/videos/Index.js
index 2ee8a775..2db5708e 100644
--- a/template/app/view/videos/Index.js
+++ b/template/app/view/videos/Index.js
@@ -4,6 +4,9 @@
 Ext.define('Docs.view.videos.Index', {
     extend: 'Ext.container.Container',
     alias: 'widget.videoindex',
+    requires: [
+        'Docs.view.videos.List'
+    ],
 
     cls: 'all-demos iScroll',
     margin: '10 0 0 0',
diff --git a/template/app/view/videos/List.js b/template/app/view/videos/List.js
index 16d147e2..f5c7b0d5 100644
--- a/template/app/view/videos/List.js
+++ b/template/app/view/videos/List.js
@@ -8,27 +8,6 @@ Ext.define('Docs.view.videos.List', {
     cls: 'demos',
     itemSelector: 'dl',
 
-    tpl: Ext.create('Ext.XTemplate',
-        '<div id="sample-ct">',
-            '<tpl for=".">',
-            '<div class="{[xindex == 1 ? "" : " collapsed"]}"><a name="{id}"></a><h2><div>{group}</div></h2>',
-            '<dl>',
-                '<tpl for="videos">',
-                    '<dd ext:id="{id}"><img src="{thumb}"/>',
-                        '<div><h4>{title}',
-                        '</h4><p>{[values.description.substr(0,100)]}</p></div>',
-                    '</dd>',
-                '</tpl>',
-            '<div style="clear:left"></div></dl></div>',
-            '</tpl>',
-        '</div>',
-        {
-            desc: function(status) {
-                return status === 'experimental';
-            }
-        }
-    ),
-
     initComponent: function() {
         this.addEvents(
             /**
@@ -39,6 +18,27 @@ Ext.define('Docs.view.videos.List', {
             'videoclick'
         );
 
+        this.tpl = Ext.create('Ext.XTemplate',
+            '<div id="sample-ct">',
+                '<tpl for=".">',
+                '<div class="{[xindex == 1 ? "" : " collapsed"]}"><a name="{id}"></a><h2><div>{group}</div></h2>',
+                '<dl>',
+                    '<tpl for="videos">',
+                        '<dd ext:id="{id}"><img src="{thumb}"/>',
+                            '<div><h4>{title}',
+                            '</h4><p>{[values.description.substr(0,100)]}</p></div>',
+                        '</dd>',
+                    '</tpl>',
+                '<div style="clear:left"></div></dl></div>',
+                '</tpl>',
+            '</div>',
+            {
+                desc: function(status) {
+                    return status === 'experimental';
+                }
+            }
+        );
+
         this.on({
             'afterrender': function(cmp) {
                 cmp.el.addListener('mouseover', function(evt, el) {
-- 
GitLab